Make sure to update all golden files when running make gen#20873
Merged
istio-testing merged 1 commit intoistio:masterfrom Feb 5, 2020
Merged
Make sure to update all golden files when running make gen#20873istio-testing merged 1 commit intoistio:masterfrom
make gen#20873istio-testing merged 1 commit intoistio:masterfrom
Conversation
jwendell
approved these changes
Feb 5, 2020
Member
|
but the unit tests fail if these are outdated? it seems a bit weird to have this in gen? |
Contributor
Author
Why? We're also re-generating the operator golden files in |
howardjohn
approved these changes
Feb 5, 2020
Member
howardjohn
left a comment
There was a problem hiding this comment.
ok I think that makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't update the
pkg/kube/injectgolden files onmake gen, which is whymake gen-checkdoesn't catch it when you forget to update them.