Skip to content

Revert "Run istio-init with non-root UID (#20380)"#20872

Merged
istio-testing merged 1 commit intoistio:masterfrom
dgn:revert-20380
Feb 6, 2020
Merged

Revert "Run istio-init with non-root UID (#20380)"#20872
istio-testing merged 1 commit intoistio:masterfrom
dgn:revert-20380

Conversation

@dgn
Copy link
Copy Markdown
Contributor

@dgn dgn commented Feb 5, 2020

This reverts commit 0996b80.

See #20863

@dgn dgn requested review from a team, costinm, howardjohn, linsun and rshriram as code owners February 5, 2020 10:11
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 5, 2020
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 5, 2020
Copy link
Copy Markdown
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did note that this PR has 125 files while the original PR had 124.

Copy link
Copy Markdown
Contributor

@esnible esnible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reviewed "istioctl" test data only.)

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Feb 5, 2020

/retest

1 similar comment
@rlenglet
Copy link
Copy Markdown
Contributor

rlenglet commented Feb 5, 2020

/retest

@rlenglet
Copy link
Copy Markdown
Contributor

rlenglet commented Feb 6, 2020

/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

@istio-testing istio-testing merged commit fa61b6a into istio:master Feb 6, 2020
@dgn dgn deleted the revert-20380 branch February 6, 2020 08:40
sdake pushed a commit to sdake/istio that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants