Skip to content

Fix sts port node metadata#20835

Merged
istio-testing merged 7 commits intoistio:masterfrom
bianpengyuan:sts
Feb 7, 2020
Merged

Fix sts port node metadata#20835
istio-testing merged 7 commits intoistio:masterfrom
bianpengyuan:sts

Conversation

@bianpengyuan
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan commented Feb 4, 2020 •
edited by istio-policy-bot
Loading

add sts port to node metadata as string instead of integer.

@bianpengyuan bianpengyuan requested review from a team as code owners February 4, 2020 05:52
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Feb 4, 2020

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 4, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2020
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Feb 4, 2020

/cherry-pick release-1.5

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 4, 2020

@bianpengyuan: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Feb 4, 2020

why? seems like port should be a number

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2020
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Feb 4, 2020

Good point. I switched back integer, except the final assignment to node metadata, which needs to be a string map.

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Feb 6, 2020

@howardjohn ptal. thanks!

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2020
@istio-testing istio-testing merged commit c6be143 into istio:master Feb 7, 2020
@istio-testing istio-testing mentioned this pull request Feb 7, 2020
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 7, 2020

@bianpengyuan: new pull request created: #20930

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JimmyCYJ JimmyCYJ mentioned this pull request Feb 20, 2020
Merged
sdake pushed a commit to sdake/istio that referenced this pull request Feb 21, 2020
@bianpengyuan
Fix sts port node metadata (istio#20835)
32434bc 
* fix sts port node metadata

* fix tes

* fix lint

* revert port to integer

* clean up

* more clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bianpengyuan @istio-policy-bot @istio-testing @howardjohn @googlebot