Remove all traces of nodeagent#20828
Merged
istio-testing merged 2 commits intoistio:masterfrom Feb 5, 2020
Merged
Conversation
ericvn
approved these changes
Feb 4, 2020
Member
|
What happens to the node agent on VMs? |
Member
Author
|
@rshriram there are 2 node agents, one is node-agent-k8s for kubernetes and the other is node-agent for VMs. This only kills node-agent-k8s, the VM stuff is still there |
6f16b0d to
ecba357
Compare
ayj
approved these changes
Feb 4, 2020
ecba357 to
a6f23d8
Compare
rshriram
approved these changes
Feb 5, 2020
myidpt
reviewed
Feb 5, 2020
There was a problem hiding this comment.
Do we still wan to keep the istiod flag? How does it work if istiod is diabled?
Member
Author
There was a problem hiding this comment.
I am going to remove the istiod flag next PR
There was a problem hiding this comment.
This CA_ADDR is hardcoded to istio-pilot. We need to make it configurable to be able to use other CAs (such as Google CA). But that can be done in another PR.
myidpt
approved these changes
Feb 5, 2020
a6f23d8 to
032de6a
Compare
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Feb 21, 2020
* Remove all traces of nodeagent Followup to istio#20777 * remove binary build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #20777