Skip to content

Setup ExternalName instances only for specified ports#20755

Merged
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:pilot/external-name-same-port
Feb 6, 2020
Merged

Setup ExternalName instances only for specified ports#20755
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:pilot/external-name-same-port

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Jan 31, 2020 •
edited by istio-policy-bot
Loading

For #13479

Not sure if this is the right way to go

@howardjohn
Setup ExternalName instances only for specified ports
641176a 
For istio#13479

Not sure if this is the right way to go
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 31, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 31, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2020
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2020
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Feb 1, 2020

/retest

@howardjohn howardjohn marked this pull request as ready for review February 1, 2020 18:54
@howardjohn howardjohn requested a review from a team as a code owner February 1, 2020 18:54
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 1, 2020
@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Feb 6, 2020

sorry, i missed this pr.

hzxuzhonghu
hzxuzhonghu approved these changes Feb 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug.

@istio-testing istio-testing merged commit 216ce9b into istio:master Feb 6, 2020
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Feb 6, 2020

/cherrypick release-1.5

@istio-testing istio-testing mentioned this pull request Feb 6, 2020
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 6, 2020

@howardjohn: new pull request created: #20889

Details

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdake pushed a commit to sdake/istio that referenced this pull request Feb 21, 2020
@howardjohn
Setup ExternalName instances only for specified ports (istio#20755)
e433e34 
* Setup ExternalName instances only for specified ports

For istio#13479

Not sure if this is the right way to go

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@howardjohn @hzxuzhonghu @istio-testing @googlebot