Look up and set the availability zone of a proxy using the --availabilityZone envoy flag#2054
Merged
rshriram merged 1 commit intoistio:masterfrom Dec 12, 2017
liamawhite:master
Merged
Look up and set the availability zone of a proxy using the --availabilityZone envoy flag#2054rshriram merged 1 commit intoistio:masterfrom liamawhite:master
rshriram merged 1 commit intoistio:masterfrom
liamawhite:master
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
rshriram
approved these changes
Dec 12, 2017
Member
rshriram
left a comment
There was a problem hiding this comment.
Yes, and we need a multi-az test cluster. Lets merge this for now, as we have no way of testing this on a day to day basis, yet.
istio-merge-robot
pushed a commit
that referenced
this pull request
Jan 10, 2018
Automatic merge from submit-queue. Add in consul datacenter (AvailabilityZone) support What this PR does / why we need it: Currently we only support AZ routing for kube based service registries. This enables it for consul. Which issue this PR fixes: Continues on from: istio/old_pilot_repo#1230, #2054 and #1815 Working towards: #1473 Release note: Enable consul intra-datacenter routing with AvailabilityZone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It is needed to allow proxy agent to set the availability zone of a proxy using the --availabilityZone flag
Which issue this PR fixes:
Continues on from: istio/old_pilot_repo#1230 and #1815
Working towards: #1473
Special notes for your reviewer: This needs testing but would like some advice on how to go about it!
Release note:
cc @rshriram