Add stats and metadata wasm plugin into proxy image#20259
Add stats and metadata wasm plugin into proxy image#20259istio-testing merged 3 commits intoistio:masterfrom
Conversation
Makefile.core.mk
Outdated
| export ISTIO_ENVOY_MACOS_RELEASE_PATH ?= ${ISTIO_ENVOY_MACOS_RELEASE_DIR}/${ISTIO_ENVOY_MACOS_RELEASE_NAME} | ||
|
|
||
| # Variable for WebAssembly plugins | ||
| export STATS_FILTER_WASM_URL ?= $(ISTIO_ENVOY_BASE_URL)/stats-$(ISTIO_ENVOY_VERSION).wasm |
There was a problem hiding this comment.
We should just have a “list_of_plugins” var instead of specific variables per plugin.
There was a problem hiding this comment.
Simplified the variables with a for loop.
|
@howardjohn 1.8m combined. |
|
ok, lgtm then
…On Fri, Jan 17, 2020 at 9:56 AM Pengyuan Bian ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn> 1.8m combined.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20259?email_source=notifications&email_token=AAEYGXJ4F7ZAFSEFI4XREDDQ6HWK5A5CNFSM4KIDJKIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPDLY#issuecomment-575730095>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXM6BJIJUF34ROGXAZDQ6HWK5ANCNFSM4KIDJKIA>
.
|
| COPY envoy_telemetry.yaml.tmpl /etc/istio/proxy/envoy_telemetry.yaml.tmpl | ||
|
|
||
| COPY stats-filter.wasm /etc/istio/proxy/stats-filter.wasm | ||
| COPY metadata-exchange-filter.wasm /etc/istio/proxy/metadata-exchange-filter.wasm |
There was a problem hiding this comment.
This just allows us to use it, it doesn't require it right? The config is from the EnvoyFilter?
There was a problem hiding this comment.
Yeah these are the v8 based plugins, and yeah there will be option to enable them if they pass stability and perf test.
|
I approved but put a hold on case others want to review |
| COPY envoy_policy.yaml.tmpl /etc/istio/proxy/envoy_policy.yaml.tmpl | ||
| COPY envoy_telemetry.yaml.tmpl /etc/istio/proxy/envoy_telemetry.yaml.tmpl | ||
|
|
||
| COPY stats-filter.wasm /etc/istio/proxy/stats-filter.wasm |
There was a problem hiding this comment.
We want this to be /etc/istio/proxy/extensions
That way we / customer can mount over this dir.
There was a problem hiding this comment.
Yeah, looks like mounting on the same path will remove these files. Shall we reserve /etc/istio/proxy/extensions for user provided plugins and keep these two plugins where they are now?
There was a problem hiding this comment.
Overmounting indeed replaces the directory , it is not unionfs.
Rethinking, We should treat the two wasm modules as if they are compiled in. Given that, it does not have to be in the extensions dir, since we expect extension names to be versioned and these names are not.
You can keep it as it is, I will change it later if needed .
|
if they mount over the dir it removes these, it doesn't merge (I think).
Not sure if that is expected or not
…On Fri, Jan 17, 2020, 7:25 PM mandarjog ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pilot/docker/Dockerfile.proxyv2
<#20259 (comment)>:
> @@ -52,5 +52,8 @@ COPY envoy_pilot.yaml.tmpl /etc/istio/proxy/envoy_pilot.yaml.tmpl
COPY envoy_policy.yaml.tmpl /etc/istio/proxy/envoy_policy.yaml.tmpl
COPY envoy_telemetry.yaml.tmpl /etc/istio/proxy/envoy_telemetry.yaml.tmpl
+COPY stats-filter.wasm /etc/istio/proxy/stats-filter.wasm
We want this to be /etc/istio/proxy/extensions
That way we / customer can mount over this dir.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20259?email_source=notifications&email_token=AAEYGXPNMFZJBMIAFJSRRUDQ6JZA7A5CNFSM4KIDJKIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHRQ5Y#pullrequestreview-344922231>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXLHV7L2Y2C5H6PAF3TQ6JZA7ANCNFSM4KIDJKIA>
.
|
fyi @duderino @mandarjog