disable listener filter timeout for outbound listener if port name is defined as tls or https#20248
Merged
istio-testing merged 6 commits intoistio:masterfrom Jan 18, 2020
Merged
disable listener filter timeout for outbound listener if port name is defined as tls or https#20248istio-testing merged 6 commits intoistio:masterfrom
istio-testing merged 6 commits intoistio:masterfrom
Conversation
Member
Author
|
@rshriram sent a PR to disable the timeout for outbound listener with tls inspector only as discussed. PTAL, thanks! |
howardjohn
reviewed
Jan 17, 2020
This reverts commit 6a1aec9.
hzxuzhonghu
reviewed
Jan 17, 2020
Member
|
you are doing `if x=x`
…On Thu, Jan 16, 2020, 8:11 PM Yan Xue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pilot/pkg/networking/core/v1alpha3/listener.go
<#20248 (comment)>:
> @@ -2334,3 +2335,22 @@ func isFallthroughFilterChain(fc *listener.FilterChain) bool {
}
return false
}
+
+func removeListenerFilterTimeout(listeners []*xdsapi.Listener) {
+ for _, l := range listeners {
+ // Remove listener filter timeout for
+ // 1. outbound listeners AND
+ // 2. with HTTP inspector
+ hasHttpInspector := false
+ for _, lf := range l.ListenerFilters {
+ if hasHttpInspector = hasHttpInspector || lf.Name == wellknown.HttpInspector; hasHttpInspector {
Could you be more clear?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20248?email_source=notifications&email_token=AAEYGXPSL6OPBQKTRUEF47DQ6EVXBA5CNFSM4KH4HRR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSDHC3A#discussion_r367761745>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXI3QTMYJRPUVBQ4ZLDQ6EVXBANCNFSM4KH4HRRQ>
.
|
Member
Author
|
The assignment has lower priority than Logical OR. You should read as |
Member
|
I think we should not do an assignment in the if.. it's just confusing for
no benefit
…On Thu, Jan 16, 2020, 8:19 PM Yan Xue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pilot/pkg/networking/core/v1alpha3/listener.go
<#20248 (comment)>:
> @@ -2334,3 +2335,22 @@ func isFallthroughFilterChain(fc *listener.FilterChain) bool {
}
return false
}
+
+func removeListenerFilterTimeout(listeners []*xdsapi.Listener) {
+ for _, l := range listeners {
+ // Remove listener filter timeout for
+ // 1. outbound listeners AND
+ // 2. with HTTP inspector
+ hasHttpInspector := false
+ for _, lf := range l.ListenerFilters {
+ if hasHttpInspector = hasHttpInspector || lf.Name == wellknown.HttpInspector; hasHttpInspector {
= has lower priority than ||. It will do || first and assignment later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20248?email_source=notifications&email_token=AAEYGXKP7YYXE6BPSJV3WJLQ6EWURA5CNFSM4KH4HRR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSDHOOA#discussion_r367763002>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXNCHLEXURPPJXBSMKDQ6EWURANCNFSM4KH4HRRQ>
.
|
Member
Author
|
/retest |
rshriram
approved these changes
Jan 17, 2020
Member
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
This was referenced Jan 21, 2020
Contributor
|
@hzxuzhonghu @howardjohn Is it planned to cherry pick this to a 1.4.x patch? It'd be great to have a 1.4.10 containing this 😁 |
Member
|
No, 1.4 is out of support:
https://istio.io/latest/news/support/announcing-1.4-eol-final/
…On Wed, Jun 10, 2020 at 3:09 PM chrisob ***@***.***> wrote:
@hzxuzhonghu <https://github.com/hzxuzhonghu> @howardjohn
<https://github.com/howardjohn> Is it planned to cherry pick this to a
1.4.x patch? It'd be great to have a 1.4.10 containing this 😁
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20248 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXK6EGIGL36WPAATIULRWAABHANCNFSM4KH4HRRQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable listener filter timeout if the port name is defined as tls or https to avoid the timeout of tls inspector.
enhance #19660