Disable policy deployment by default#20213
Merged
istio-testing merged 5 commits intoistio:masterfrom Jan 18, 2020
Merged
Conversation
Member
Author
|
/retest |
Member
Author
|
Needed to add a new default "integ test" (as opposed to e2e/) default values since it hardcoded policy to enabled |
332646a to
b027e18
Compare
Member
Author
|
/retest |
b027e18 to
3582562
Compare
mandarjog
reviewed
Jan 17, 2020
operator/data/profiles/default.yaml
Outdated
Contributor
There was a problem hiding this comment.
Assuming this controls the deployment itself, lgtm
Member
Author
There was a problem hiding this comment.
Yes, this is controls the deployment
elfinhe
approved these changes
Jan 17, 2020
Member
Author
|
/retest |
3582562 to
6e4f16f
Compare
6e4f16f to
d03858e
Compare
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 19, 2020
Regression since istio#20213 We turned on policy, but disabled checks. Didn't notice since it only runs in postsubmit.
istio-testing
pushed a commit
that referenced
this pull request
Jan 19, 2020
Regression since #20213 We turned on policy, but disabled checks. Didn't notice since it only runs in postsubmit.
pull bot
pushed a commit
to lxmwq/istio
that referenced
this pull request
Jan 19, 2020
Regression since istio#20213 We turned on policy, but disabled checks. Didn't notice since it only runs in postsubmit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.