Fix bootstrap template with multiple SANs#19854
Merged
istio-testing merged 1 commit intoistio:masterfrom Dec 31, 2019
Merged
Conversation
Currently we generate invalid JSON, since we have no comma between the list. The easiest way to do this is to have a toJson function so we don't need to hack together json marshalling in the template. There are no compatibility issues because the bootstrap logic and bootstrap file are tightly coupled
dce7aec to
6ea3fc4
Compare
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
Member
Author
|
/retest
…On Mon, Dec 30, 2019, 6:41 PM Istio Automation ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
unit-tests_istio 6ea3fc4
<6ea3fc4>
link
<https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/19854/unit-tests_istio/5727> /test
unit-tests_istio
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19854?email_source=notifications&email_token=AAEYGXME5GWSDLYSSIS6I6LQ3KWO3A5CNFSM4KBR5F5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3T3OY#issuecomment-569851323>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXMUM5AT4RHWCZV7VVDQ3KWO3ANCNFSM4KBR5F5A>
.
|
ericvn
approved these changes
Dec 31, 2019
elfinhe
approved these changes
Dec 31, 2019
Member
elfinhe
left a comment
There was a problem hiding this comment.
LGTM. do we have an e2e test for the multiple SANs case?
Member
Author
|
Not yet. There are a lot of things needed to get this working e2e still, currently working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we generate invalid JSON, since we have no comma between the
list. The easiest way to do this is to have a toJson function so we
don't need to hack together json marshalling in the template. There are
no compatibility issues because the bootstrap logic and bootstrap file
are tightly coupled