Skip to content

Remove unused .yaml file#19795

Merged
istio-testing merged 1 commit intoistio:masterfrom
nak3:remove-yaml
Dec 27, 2019
Merged

Remove unused .yaml file#19795
istio-testing merged 1 commit intoistio:masterfrom
nak3:remove-yaml

Conversation

@nak3
Copy link
Copy Markdown
Member

@nak3 nak3 commented Dec 26, 2019

This patch removes mixer/adapter/kubernetesenv/config/.yaml which is
probably created by mistake. The actual file should be
mixer/adapter/kubernetesenv/config/kubernetesenv.yaml and already exist.

[X ] Policies and Telemetry

@nak3
Remove unused .yaml file
68957ca 
This patch removes `mixer/adapter/kubernetesenv/config/.yaml` which is
probably created by mistake. The actual file should be
`mixer/adapter/kubernetesenv/config/kubernetesenv.yaml` and already exist.
@nak3 nak3 requested a review from a team December 26, 2019 11:46
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 26, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Dec 26, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 26, 2019

Hi @nak3. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Copy Markdown
Member Author

nak3 commented Dec 27, 2019

Could anyone please add /ok-to-test ?

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Dec 27, 2019 via email

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 27, 2019
@istio-testing istio-testing merged commit a68b0ec into istio:master Dec 27, 2019
@nak3 nak3 deleted the remove-yaml branch December 28, 2019 01:21
@nak3 nak3 mentioned this pull request Jan 5, 2020
Closed
5 tasks
@nak3 nak3 mentioned this pull request Feb 12, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

+1 more reviewer

@bianpengyuan bianpengyuan bianpengyuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/extensions and telemetry cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nak3 @istio-testing @howardjohn @bianpengyuan @googlebot @istio-policy-bot