export PATH from shell instead of makefile#19433
export PATH from shell instead of makefile#19433maplebeats wants to merge 1 commit intoistio:masterfrom maplebeats:master
Conversation
|
Hi @maplebeats. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
howardjohn
left a comment
There was a problem hiding this comment.
I think we want to use the makefiles environment variables? isn't that what would be used normally? I am not sure the implications of change this. It seems safer to instead just add quotation marks?
|
#19774 fixed, close |
the makefile PATH use makefile environment variable now,
if the PATH have some special character , the shell execution will fail.
/bin/bash: -c: line 0: syntax error near unexpected token ('`
In general, we should use the shell's environment variables，or use quotation marks 。