Skip to content

fix(stackdriver): pull mesh uid from config#19401

Merged
istio-testing merged 1 commit intoistio:release-1.4from
douglas-reid:cherry-pick-mesh-id-1.4
Dec 11, 2019
Merged

fix(stackdriver): pull mesh uid from config#19401
istio-testing merged 1 commit intoistio:release-1.4from
douglas-reid:cherry-pick-mesh-id-1.4

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid commented Dec 4, 2019

Manual cherry-pick of #18655

@douglas-reid douglas-reid requested a review from a team December 4, 2019 23:46
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 4, 2019
@douglas-reid douglas-reid force-pushed the cherry-pick-mesh-id-1.4 branch from c56adff to eaca2f4 Compare December 5, 2019 01:45
* fix(stackdriver): pull mesh uid from config

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* rerun make gen

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
@douglas-reid douglas-reid force-pushed the cherry-pick-mesh-id-1.4 branch from eaca2f4 to a4d23e4 Compare December 5, 2019 18:09
@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Dec 5, 2019

Holding until 1.4.3

@ericvn ericvn added the do-not-merge/hold Block automatic merging of a PR. label Dec 5, 2019
@douglas-reid
Copy link
Copy Markdown
Contributor Author

/test unit-tests_istio_release-1.4

These changes should not have impacted.

@douglas-reid
Copy link
Copy Markdown
Contributor Author

/test e2e-dashboard_istio_release-1.4

@douglas-reid
Copy link
Copy Markdown
Contributor Author

/test unit-tests_istio_release-1.4

flaky envoy test.

@howardjohn howardjohn removed the do-not-merge/hold Block automatic merging of a PR. label Dec 10, 2019
@howardjohn
Copy link
Copy Markdown
Member

/retest

@istio-testing istio-testing merged commit a1fa70f into istio:release-1.4 Dec 11, 2019
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Mar 4, 2020
* fix(stackdriver): pull mesh uid from config

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* rerun make gen

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/extensions and telemetry cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants