Test using default hub and tag#1899
Conversation
|
@chxchx: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @yutongz @sebastienvas |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
+ Coverage 81.18% 81.19% +<.01%
==========================================
Files 190 187 -3
Lines 19449 18889 -560
==========================================
- Hits 15789 15336 -453
+ Misses 3197 3122 -75
+ Partials 463 431 -32
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 81.18% 81.17% -0.01%
==========================================
Files 190 191 +1
Lines 19449 19455 +6
==========================================
+ Hits 15789 15792 +3
- Misses 3197 3200 +3
Partials 463 463
Continue to review full report at Codecov.
|
tests/e2e/framework/istioctl.go
Outdated
| var ( | ||
| remotePath = flag.String("istioctl_url", os.Getenv(istioctlURL), "URL to download istioctl") | ||
| localPath = flag.String("istioctl", "", "Use local istioctl instead of remote") | ||
| testWithDefault = flag.Bool("default", false, "Test with default hub and tag") |
There was a problem hiding this comment.
Can you rename it to something like "default_sidecar" to be less confussing.
|
PTAL |
* Add integration test with JWT+AuthN+Mixer filter chain * Lint * Rename helper function * Lint * Review
What this PR does / why we need it:
To be able to test with default settings in istioctl
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: