Skip to content

Expand metric support and fix linter issues#1897

Merged
istio-merge-robot merged 2 commits intoistio:masterfrom
manlinl:linter
Nov 29, 2017
Merged

Expand metric support and fix linter issues#1897
istio-merge-robot merged 2 commits intoistio:masterfrom
manlinl:linter

Conversation

@manlinl
Copy link
Copy Markdown
Contributor

@manlinl manlinl commented Nov 28, 2017 •
edited
Loading

No description provided.

@manlinl manlinl requested a review from apicl November 28, 2017 20:01
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2017

Codecov Report

Merging #1897 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
+ Coverage   81.18%   81.71%   +0.53%     
==========================================
  Files         190      198       +8     
  Lines       19449    19906     +457     
==========================================
+ Hits        15789    16267     +478     
- Misses       3197     3200       +3     
+ Partials      463      439      -24
Flag Coverage Δ
#broker 45.51% <ø> (+1.06%) ⬆️
#mixer 83.21% <ø> (+0.75%) ⬆️
#pilot 80.4% <ø> (-0.06%) ⬇️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/svcctrl/svcctrl.go 61.16% <ø> (ø) ⬆️
pilot/model/egress_rules.go 100% <0%> (ø) ⬆️
pilot/platform/kube/inject/configmap.go
pilot/platform/kube/inject/initializer.go
pilot/platform/kube/inject/http.go
pilot/platform/kube/inject/inject.go
mixer/pkg/runtime/resourceType.go 100% <0%> (ø)
mixer/pkg/runtime/monitor.go 100% <0%> (ø)
mixer/pkg/runtime/init.go 28.33% <0%> (ø)
mixer/pkg/runtime/context.go 100% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f2fe4...1e2747b. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2017 •
edited
Loading

Codecov Report

Merging #1897 into master will decrease coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   81.72%   80.49%   -1.24%     
==========================================
  Files         202      179      -23     
  Lines       20472    17284    -3188     
==========================================
- Hits        16731    13912    -2819     
+ Misses       3271     2981     -290     
+ Partials      470      391      -79
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.38% <ø> (-0.84%) ⬇️
#pilot 78.14% <ø> (-2.37%) ⬇️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/svcctrl/reportbuilder.go 86.41% <ø> (-1.09%) ⬇️
mixer/adapter/svcctrl/svcctrl.go 61.16% <ø> (ø) ⬆️
mixer/adapter/svcctrl/testhelper.go 68.88% <ø> (-6.67%) ⬇️
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️
pilot/platform/consul/monitor.go 76.19% <0%> (-3.58%) ⬇️
mixer/pkg/config/crd/store.go 96.36% <0%> (-0.61%) ⬇️
mixer/pkg/runtime/monitor.go
pilot/proxy/envoy/policy.go
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab76cee...6fe378c. Read the comment docs.

apicl
apicl reviewed Nov 28, 2017
View reviewed changes
mixer/adapter/svcctrl/metrics.go Outdated
Copy link
Copy Markdown
Contributor

@apicl apicl Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not support the error_count metric. In future, we are going to delete this metric.

Copy link
Copy Markdown
Contributor Author

@manlinl manlinl Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@manlinl manlinl added the do-not-merge Block automatic merging of a PR. label Nov 29, 2017
@manlinl manlinl removed do-not-merge Block automatic merging of a PR. do-not-merge/post-submit labels Nov 29, 2017
@apicl
Copy link
Copy Markdown
Contributor

apicl commented Nov 29, 2017

/lgtm

@apicl
Copy link
Copy Markdown
Contributor

apicl commented Nov 29, 2017

/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 29, 2017

@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manlinl
Copy link
Copy Markdown
Contributor Author

manlinl commented Nov 29, 2017

/test istio-presubmit

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @apicl @manlinl

@manlinl
Copy link
Copy Markdown
Contributor Author

manlinl commented Nov 29, 2017

/retest all

@apicl
Copy link
Copy Markdown
Contributor

apicl commented Nov 29, 2017

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apicl

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 29, 2017

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit b3d6fa1 into istio:master Nov 29, 2017
@manlinl manlinl deleted the linter branch November 29, 2017 18:17
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@mandarjog
add context.proxy_error_code to report attributes (istio#1897)
3f528b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apicl apicl apicl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@apicl apicl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manlinl @apicl @istio-testing @istio-merge-robot @googlebot