Stop using span pools for Mixer tracing.#1893
Conversation
|
@douglas-reid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We have been unable to reproduce the error, however reusing spans can cause an NPE like this, so going ahead with this change. /lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandarjog, sebastienvas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1893 +/- ##
==========================================
- Coverage 81.67% 81.15% -0.53%
==========================================
Files 201 186 -15
Lines 20447 18883 -1564
==========================================
- Hits 16701 15324 -1377
+ Misses 3275 3128 -147
+ Partials 471 431 -40
Continue to review full report at Codecov.
|
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
…filter. (istio#1893) * Using dynamicMetadata to pass data between filters instead of headers * Lint * Populate authn result to dynamic data only. * Integration test for authn * Clean up and verify all tests * Remove unused test configs * Address reviews * Lint
What this PR does / why we need it:
Turns span pooling off. Observing race conditions in post-submits related to spans. This will eliminate a potential source of those race conditions.
Note: I have not been able to locally repro the span issues, but based on Mixer architecture and warnings surrounding
PoolSpans, I believe this to be a likely source of the race.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: