consolidate scripts in bin directory in istio components#1875
consolidate scripts in bin directory in istio components#1875rshriram merged 1 commit intoistio:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
|
/assign @geeknoid |
rshriram
left a comment
There was a problem hiding this comment.
Could you rename to scripts/ ?
|
And please fix circleci broker test. |
|
I rather have a single "bin" directory which contains everything that can be run, whether an actual binary or a script. It doesn't matter to the user of this thing, except for having the thing in their path. |
Codecov Report
@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
- Coverage 81.23% 81.19% -0.05%
==========================================
Files 191 186 -5
Lines 19344 18772 -572
==========================================
- Hits 15715 15242 -473
+ Misses 3173 3103 -70
+ Partials 456 427 -29
Continue to review full report at Codecov.
|
|
the broker failure looks like circleci's flake. rerun seems to fix the issue. I don't have strong opinion on the name of directories, but it's been |
|
Thank you for merging, but please don't merge changes like this manually. Some other things are merged meanwhile, which makes the presubmit fail. See #1890 |
|
Shouldn't those changes respect the style/lint etc. ? |
1. Stop trashing build's cache. 2. Split ASan and TSan tests into separate targets. 3. Fix output directory, so that caching works on macOS. Before: - build : 49 mins - macos : 30 mins After: - build : 27 mins - linux_asan: 20 mins - linux_tsan: 16 mins - macos : 30 mins After (with warm cache): - build : 3 mins - linux_asan: 4 mins - linux_tsan: 2 mins - macos : 5 mins Fixes istio#1815. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1844Special notes for your reviewer:
Release note: