Skip to content

Add execute bit to make shell scripts executable#1874

Merged
rshriram merged 1 commit intoistio:masterfrom
baodongli:issues/1872
Nov 28, 2017
Merged

Add execute bit to make shell scripts executable#1874
rshriram merged 1 commit intoistio:masterfrom
baodongli:issues/1872

Conversation

@baodongli
Copy link
Copy Markdown

@baodongli baodongli commented Nov 27, 2017

What this PR does / why we need it:
Add execute bit to the shell scripts under ./bin to make them executable.
./bin/pre-commit and ./bin/docker_lib.sh are missing the execute bit and can't be executed.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1872

Special notes for your reviewer:

Release note:

None

@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @baodongli. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1874 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   81.23%   81.22%   -0.02%     
==========================================
  Files         191      191              
  Lines       19344    19344              
==========================================
- Hits        15715    15712       -3     
- Misses       3173     3176       +3     
  Partials      456      456
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.51% <ø> (-0.03%) ⬇️
#pilot 80.47% <ø> (ø) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85983c2...f3ada25. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1874 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   81.23%   81.22%   -0.02%     
==========================================
  Files         191      191              
  Lines       19344    19344              
==========================================
- Hits        15715    15712       -3     
- Misses       3173     3176       +3     
  Partials      456      456
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.51% <ø> (-0.03%) ⬇️
#pilot 80.47% <ø> (ø) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85983c2...f3ada25. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2017

Codecov Report

Merging #1874 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   81.23%   81.22%   -0.02%     
==========================================
  Files         191      191              
  Lines       19344    19344              
==========================================
- Hits        15715    15712       -3     
- Misses       3173     3176       +3     
  Partials      456      456
Flag Coverage Δ
#broker 45.51% <ø> (ø) ⬆️
#mixer 82.51% <ø> (-0.03%) ⬇️
#pilot 80.47% <ø> (ø) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mixer/adapter/prometheus/server.go 89.83% <0%> (-5.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85983c2...f3ada25. Read the comment docs.

@rshriram
Copy link
Copy Markdown
Member

/ok-to-test

@rshriram rshriram merged commit 51d9eff into istio:master Nov 28, 2017
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some shell scripts under ./bin don't have execute bit set in the file mode

6 participants