Skip to content

Use variables to render envoy telemetry template#18734

Merged
istio-testing merged 1 commit intoistio:masterfrom
ChangyuWang:telemetry-template
Nov 7, 2019
Merged

Use variables to render envoy telemetry template#18734
istio-testing merged 1 commit intoistio:masterfrom
ChangyuWang:telemetry-template

Conversation

@ChangyuWang
Copy link
Copy Markdown
Member

@ChangyuWang ChangyuWang commented Nov 7, 2019

Render envoy_telemetry.yaml.tmpl by variables instead of static value population

@ChangyuWang ChangyuWang requested a review from a team as a code owner November 7, 2019 08:31
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2019
@ChangyuWang
Copy link
Copy Markdown
Member Author

/retest

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 7, 2019

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-istioio-k8s-tests_istio bbe854a link /test integ-istioio-k8s-tests_istio
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 39f6eff into istio:master Nov 7, 2019
@ChangyuWang ChangyuWang deleted the telemetry-template branch November 8, 2019 09:21
sdake pushed a commit to sdake/istio that referenced this pull request Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config area/extensions and telemetry cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants