fix(mixer plugin): do not add HTTP filter when check and report disabled#18717
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 6, 2019
Merged
Conversation
…eport disabled Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Contributor
Author
|
/cherry-pick release-1.4 |
Contributor
Author
|
/cherrypick release-1.4 |
Collaborator
|
@douglas-reid: new pull request created: #18721 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
…eport disabled (istio#18717) Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For HTTP, if the HTTP reports are disabled AND policy checks are also disabled, instead of generating a filter that has all functionality disabled, this PR will just skip filter generation altogether.
Addresses #18586
Signed-off-by: Douglas Reid douglas-reid@users.noreply.github.com