Fix nil stackdriver environment variables#18710
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 7, 2019
Merged
Conversation
howardjohn
approved these changes
Nov 6, 2019
Member
howardjohn
left a comment
There was a problem hiding this comment.
Need port to istio/installer
Contributor
Author
@howardjohn : where do we need to make changes for that? |
Member
|
/retest |
1 similar comment
Member
|
/retest |
Member
|
/retest
…On Wed, Nov 6, 2019, 10:00 PM Istio Automation ***@***.***> wrote:
@gargnupur <https://github.com/gargnupur>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
unit-tests_istio d97a960
<d97a960>
link
<https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/18710/unit-tests_istio/3811> /test
unit-tests_istio
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18710?email_source=notifications&email_token=AAEYGXJPCSAUL6PKUAAVFK3QSOVGTA5CNFSM4JJ5MBFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDKS37I#issuecomment-550841853>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXNKO3IRSW7E47QM4VTQSOVGTANCNFSM4JJ5MBFA>
.
|
Contributor
Author
|
@mandarjog : cherrypick this to 1.4? |
Contributor
Author
|
/cherry-pick release-1.4 |
Collaborator
|
@gargnupur: new pull request created: #18812 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nil stackdriver environment variables.
Ref: #18680