Skip to content

Add a local CONTRIBUTING.md file that points to the main one on istio/community#1871

Merged
geeknoid merged 1 commit intoistio:masterfrom
geeknoid:contrib
Nov 27, 2017
Merged

Add a local CONTRIBUTING.md file that points to the main one on istio/community#1871
geeknoid merged 1 commit intoistio:masterfrom
geeknoid:contrib

Conversation

@geeknoid
Copy link
Copy Markdown
Contributor

@geeknoid geeknoid commented Nov 27, 2017

Having this file present helps our community-friendly rating that GitHub maintains.

Add a local CONTRIBUTING.md file that points to the main one on istio…
be34ff9 
…/community.

Having this file present helps our community-friendly rating that GitHub maintains.
@geeknoid geeknoid requested a review from rshriram November 27, 2017 20:35
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 27, 2017

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Nov 27, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: douglas-reid

Assign the PR to them by writing /assign @douglas-reid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2017 •
edited
Loading

Codecov Report

Merging #1871 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1871     +/-   ##
=========================================
+ Coverage   81.68%   81.89%   +0.2%     
=========================================
  Files         135      188     +53     
  Lines       11537    18715   +7178     
=========================================
+ Hits         9424    15326   +5902     
- Misses       1920     2962   +1042     
- Partials      193      427    +234
Flag Coverage Δ
#broker 44.44% <ø> (-1.07%) ⬇️
#mixer 82.49% <ø> (ø) ⬆️
#pilot 82.23% <ø> (?)
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
broker/pkg/version/version.go
pilot/proxy/resolve.go 0% <0%> (ø)
pilot/proxy/context.go 81.01% <0%> (ø)
pilot/adapter/config/memory/monitor.go 89.74% <0%> (ø)
pilot/platform/kube/cache.go 66.66% <0%> (ø)
pilot/adapter/config/crd/types.go 62.26% <0%> (ø)
pilot/model/controller.go 100% <0%> (ø)
pilot/proxy/envoy/discovery.go 75.51% <0%> (ø)
pilot/proxy/agent.go 100% <0%> (ø)
pilot/adapter/config/memory/config.go 100% <0%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1903f78...be34ff9. Read the comment docs.

@geeknoid geeknoid merged commit be0e20d into istio:master Nov 27, 2017
vadimeisenbergibm pushed a commit to vadimeisenbergibm/istio that referenced this pull request Nov 28, 2017
@geeknoid @vadimeisenbergibm
Add a local CONTRIBUTING.md file that points to the main one on istio…
b671c67 
…/community. (istio#1871)

Having this file present helps our community-friendly rating that GitHub maintains.
@mattdelco
Copy link
Copy Markdown
Contributor

mattdelco commented Nov 28, 2017

This file was also included in the release tars, so when the file got removed and broke the release build I removed the file from the list that's included in the tarball. I'll leave the situation as-is (i.e., file still not included in tarball) unless I hear otherwise.

@geeknoid geeknoid deleted the contrib branch February 28, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@geeknoid @istio-testing @istio-merge-robot @mattdelco @rshriram @googlebot