Skip to content

Remove a log message from Citadel agent.#18703

Merged
istio-testing merged 2 commits intoistio:masterfrom
JimmyCYJ:node-agent-fix
Nov 6, 2019
Merged

Remove a log message from Citadel agent.#18703
istio-testing merged 2 commits intoistio:masterfrom
JimmyCYJ:node-agent-fix

Conversation

@JimmyCYJ
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ commented Nov 6, 2019

The log message does not check if passed pointer is nil, and the message is redundant. Remove this message.

#18688

@JimmyCYJ JimmyCYJ requested a review from a team November 6, 2019 19:11
@JimmyCYJ JimmyCYJ requested a review from a team as a code owner November 6, 2019 19:11
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #18705

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #18706

@JimmyCYJ JimmyCYJ deleted the node-agent-fix branch November 6, 2019 21:19
sdake pushed a commit to sdake/istio that referenced this pull request Dec 1, 2019
* fix node agent crash

* revert change to mixer_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants