Add structured format options to istioctl analyze#18700
Merged
istio-testing merged 7 commits intoistio:masterfrom Nov 8, 2019
Merged
Add structured format options to istioctl analyze#18700istio-testing merged 7 commits intoistio:masterfrom
istio-testing merged 7 commits intoistio:masterfrom
Conversation
jasonwzm
reviewed
Nov 6, 2019
sushicw
reviewed
Nov 6, 2019
Contributor
Author
|
/retest |
sushicw
approved these changes
Nov 7, 2019
howardjohn
reviewed
Nov 7, 2019
Member
howardjohn
left a comment
There was a problem hiding this comment.
tried it locally, looks good
Should we output Error: Analyzer found issues. when using json/yaml? Its not so bad since it goes to stderr so you can still do things like | jq ..
added 7 commits
November 7, 2019 12:27
See istio#18306. On its own this doesn't do anything, just adds a flag and sets a default output format to the current format.
5f1e83c to
13c8a55
Compare
Contributor
|
/test integ-pilot-k8s-tests_istio |
esnible
approved these changes
Nov 7, 2019
Contributor
Author
|
/retest |
ayj
approved these changes
Nov 8, 2019
Member
|
/retest |
selmanj
pushed a commit
to selmanj/istio
that referenced
this pull request
Nov 27, 2019
* Add flag to control output format for analyze See istio#18306. On its own this doesn't do anything, just adds a flag and sets a default output format to the current format. * Add MarshalJSON function for Message struct * Add Json as an output format option to analyze * Add YAML as an output format to analyze * Update style re: PR feedback * Use Unstructured for json marshaling messages * Indent JSON output by default in analyze
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
* Add flag to control output format for analyze See istio#18306. On its own this doesn't do anything, just adds a flag and sets a default output format to the current format. * Add MarshalJSON function for Message struct * Add Json as an output format option to analyze * Add YAML as an output format to analyze * Update style re: PR feedback * Use Unstructured for json marshaling messages * Indent JSON output by default in analyze
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #18306