readiness revert to update status stats#18685
Merged
istio-testing merged 3 commits intoistio:masterfrom Nov 7, 2019
Merged
Conversation
howardjohn
approved these changes
Nov 6, 2019
Contributor
Author
|
/retest |
Member
Contributor
Author
|
@howardjohn Timeouts are very surprising though. Suspecting that reducing the timeout to 1s causing these many timeouts? |
Contributor
Author
|
/retest |
Collaborator
|
@ramaraochavali: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
@howardjohn this got merged. So let us leave it with this for now and when we find a problem with hot-restarts may be we can revive my fix if needed |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If readiness probe continues to have issues after #18679 , this PR is to get back to the old functionality