Support one handler for mulitple GCP services and fixes#1867
Support one handler for mulitple GCP services and fixes#1867istio-merge-robot merged 2 commits intoistio:masterfrom manlinl:int2
Conversation
|
@manlinl: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1867 +/- ##
==========================================
+ Coverage 81.9% 82.34% +0.44%
==========================================
Files 188 200 +12
Lines 18715 19783 +1068
==========================================
+ Hits 15328 16291 +963
- Misses 2960 3053 +93
- Partials 427 439 +12
Continue to review full report at Codecov.
|
- Allow one handler handles multiple GCP services - Expand metric support - Minor fixes in reportBuilder
mixer/adapter/svcctrl/handler.go
Outdated
| svcProc, err := h.getServiceProcessor(ctx) | ||
| if err != nil { | ||
| return adapter.QuotaResult{ | ||
| Status: status.WithPermissionDenied(err.Error()), |
There was a problem hiding this comment.
Is this internal error? It does not look like a permission issue.
|
|
||
| // lock protects svcProcMap. | ||
| lock sync.Mutex | ||
| svcProcMap map[string]*serviceProcessor |
There was a problem hiding this comment.
Please comment what's the key/value?
|
|
||
| func newHandler(ctx *handlerContext) (*handler, error) { | ||
| return &handler{ | ||
| ctx: ctx, |
|
|
||
| // lock protects svcProcMap. | ||
| lock sync.Mutex | ||
| svcProcMap map[string]*serviceProcessor |
mixer/adapter/svcctrl/handler.go
Outdated
| svcProc, err := h.getServiceProcessor(ctx) | ||
| if err != nil { | ||
| return adapter.QuotaResult{ | ||
| Status: status.WithPermissionDenied(err.Error()), |
|
|
||
| func newHandler(ctx *handlerContext) (*handler, error) { | ||
| return &handler{ | ||
| ctx: ctx, |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apicl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test istio-pilot-e2e |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Automatic merge from submit-queue. Support one handler for mulitple GCP services and fixes - Allow one handler handles multiple GCP services - Expand metric support - Minor fixes in reportBuilder
Uh oh!
There was an error while loading. Please reload this page.