Skip to content

turn on protocol sniffing for inbound#18666

Merged
istio-testing merged 1 commit intoistio:masterfrom
yxue:sniff
Nov 6, 2019
Merged

turn on protocol sniffing for inbound#18666
istio-testing merged 1 commit intoistio:masterfrom
yxue:sniff

Conversation

@yxue
Copy link
Copy Markdown
Member

@yxue yxue commented Nov 5, 2019

Turn on protocol sniffing for inbound

@yxue yxue requested review from a team as code owners November 5, 2019 21:52
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 5, 2019
@howardjohn
Copy link
Copy Markdown
Member

Can you provide more context on why we decided to do this now and why it is safe now (if it is)?

@yxue
Copy link
Copy Markdown
Member Author

yxue commented Nov 6, 2019

/retest

@yxue
Copy link
Copy Markdown
Member Author

yxue commented Nov 6, 2019

Using unnamed ports is unsecured as expected and it's part of permissive mode. We are going to document the situation and remind the user to use named ports, strict mTLS for security.

@yxue
Copy link
Copy Markdown
Member Author

yxue commented Nov 6, 2019

/retest

@istio-testing istio-testing merged commit a565a46 into istio:master Nov 6, 2019
sdake pushed a commit to sdake/istio that referenced this pull request Dec 1, 2019
@yxue yxue deleted the sniff branch December 18, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants