Guard pilot debug api against indefinite locks#18627
Merged
istio-testing merged 2 commits intoistio:masterfrom Nov 5, 2019
Merged
Guard pilot debug api against indefinite locks#18627istio-testing merged 2 commits intoistio:masterfrom
istio-testing merged 2 commits intoistio:masterfrom
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
Contributor
Author
|
/cherrypick release-1.4 |
Collaborator
|
@therealmitchconnors: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
howardjohn
previously approved these changes
Nov 5, 2019
Contributor
Author
|
/test gencheck_istio |
howardjohn
approved these changes
Nov 5, 2019
Contributor
Author
|
/retest |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
* Guard pilot debug api against indefinite locks * remove func wrapper for debug api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18519