add collector endpoint version for zipkin#18592
Merged
istio-testing merged 4 commits intoistio:masterfrom Nov 6, 2019
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
commented
Nov 4, 2019
| "config": { | ||
| "collector_cluster": "zipkin", | ||
| "collector_endpoint": "/api/v1/spans", | ||
| "collector_endpoint": "/api/v2/spans", |
Contributor
Author
There was a problem hiding this comment.
not sure if this causes any backward compatible issues? If so, I can close this PR
Member
There was a problem hiding this comment.
this applies only to the newer proxies. Older ones still have the older bootstrap
rshriram
approved these changes
Nov 5, 2019
brian-avery
approved these changes
Nov 5, 2019
Contributor
Author
|
@howardjohn Can you PTAL? |
howardjohn
approved these changes
Nov 6, 2019
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
* add collector endpoint version for zipkin Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * change api in tests Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * change back api in tests Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * move to v2 spans Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy now expects the collector endpoint version to be set correctly (not use the default) https://github.com/envoyproxy/envoy/blob/master/api/envoy/config/trace/v2/trace.proto#L76. This PR sets the collector endpoint version in the template