Skip to content

Make linking the kubeconfig idempotent.#1852

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
joerg84:linking
Nov 27, 2017
Merged

Make linking the kubeconfig idempotent.#1852
istio-merge-robot merged 1 commit intoistio:masterfrom
joerg84:linking

Conversation

@joerg84
Copy link
Copy Markdown

@joerg84 joerg84 commented Nov 23, 2017

Previously there were situations where we needed to manually unlink the config, e.g., after build errors.

NONE

@istio-testing
Copy link
Copy Markdown
Collaborator

@joerg84: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @joerg84. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joerg84
Copy link
Copy Markdown
Author

joerg84 commented Nov 23, 2017

/assign @douglas-reid

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 23, 2017

Codecov Report

Merging #1852 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   82.56%   82.55%   -0.01%     
==========================================
  Files         202      196       -6     
  Lines       19849    19047     -802     
==========================================
- Hits        16389    15725     -664     
+ Misses       3015     2920      -95     
+ Partials      445      402      -43
Flag Coverage Δ
#broker 45.51% <ø> (+1.06%) ⬆️
#mixer 83.6% <ø> (-0.07%) ⬇️
#pilot 82.08% <ø> (+0.07%) ⬆️
#security 90.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pilot/adapter/config/memory/monitor.go 79.48% <0%> (-10.26%) ⬇️
pilot/platform/kube/inject/inject.go
mixer/test/handler.go
mixer/pkg/il/evaluator/checker.go
pilot/platform/kube/inject/initializer.go
mixer/pkg/il/evaluator/evaluator.go
pilot/platform/kube/inject/http.go
pilot/platform/kube/inject/configmap.go
mixer/test/server.go
pilot/tools/version/version.go 100% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e04fa...a2cd457. Read the comment docs.

@douglas-reid
Copy link
Copy Markdown
Contributor

/ok-to-test

@douglas-reid
Copy link
Copy Markdown
Contributor

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 1903f78 into istio:master Nov 27, 2017
vadimeisenbergibm pushed a commit to vadimeisenbergibm/istio that referenced this pull request Nov 28, 2017
Automatic merge from submit-queue.

Make linking the kubeconfig idempotent.

Previously there were situations where we needed to manually unlink the config, e.g., after build errors.

```release-note
NONE
```
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants