Clean up legacy Discovery v1 server#18474
Merged
istio-testing merged 2 commits intoistio:masterfrom Nov 5, 2019
Merged
Conversation
Right now we have two discovery servers - v1 and v2. The v1 server basically does nothing, except expose a single unused debugging endpoint. This PR kills the v1 discovery server, and moves the only part that is used (setting up the profile endpoints) to its appropriate location in InitDebug.
hzxuzhonghu
approved these changes
Oct 31, 2019
rshriram
approved these changes
Nov 5, 2019
brian-avery
approved these changes
Nov 5, 2019
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
* Clean up legacy Discovery v1 server Right now we have two discovery servers - v1 and v2. The v1 server basically does nothing, except expose a single unused debugging endpoint. This PR kills the v1 discovery server, and moves the only part that is used (setting up the profile endpoints) to its appropriate location in InitDebug. * Fix integ tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we have two discovery servers - v1 and v2. The v1 server
basically does nothing, except expose a single unused debugging
endpoint.
This PR kills the v1 discovery server, and moves the only part that is
used (setting up the profile endpoints) to its appropriate location in
InitDebug.