Add ingress service for correct status IP#177
Merged
kyessenov merged 1 commit intoistio:masterfrom May 2, 2017
Merged
Conversation
Collaborator
|
Jenkins job istio/presubmit passed |
1 similar comment
Collaborator
|
Jenkins job istio/presubmit passed |
Contributor
|
Can you elaborate on what does it do? |
Contributor
Author
|
Sets the external IP correctly on ingress resources. Please try it and confirm. Seems to work here. |
Contributor
Author
ldemailly
approved these changes
May 2, 2017
Member
ldemailly
left a comment
There was a problem hiding this comment.
lgtm, thank you! it'd be nice one of our tests exercise this
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
* Add Istio auth configuration instructions. * Remove Istio per-cluster CA deployment.
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
…imeout (istio#177) Make the mixer robust to adapter panics by adding a `recover` to the adapterManager's execute method, so that it will always return either a result or an err even if adapter code panics. Additionally, handle request cancellation and timeout in methodHandlers's dispatch loop by polling the context on each iteration to see if we should stop. Former-commit-id: c3cef147a233502e2d9b2d5c45e1a7f1d3cf07a7
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
Add ingress service for correct status IP Former-commit-id: 75086a8
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
…imeout (#177) Make the mixer robust to adapter panics by adding a `recover` to the adapterManager's execute method, so that it will always return either a result or an err even if adapter code panics. Additionally, handle request cancellation and timeout in methodHandlers's dispatch loop by polling the context on each iteration to see if we should stop. Former-commit-id: a5570653809f9632893a186a4e90fb10f34d5102
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
Add ingress service for correct status IP Former-commit-id: 75086a8
rajusharma
pushed a commit
to rajusharma/istio
that referenced
this pull request
Jul 2, 2019
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Update README * Review comments * Review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.