Fix submessage support part1#1736
Conversation
|
@guptasu: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. DetailsOne of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm (already previously approved and submitted). |
|
/retest ci/circleci |
|
/test ci/circleci |
|
/testall |
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @geeknoid @guptasu |
|
/retest |
|
@geeknoid @douglas-reid re-lgtm please |
|
/lgtm
…On Wed, Nov 15, 2017 at 10:11 PM, Sunny Gupta ***@***.***> wrote:
@geeknoid <https://github.com/geeknoid> @douglas-reid
<https://github.com/douglas-reid> re-lgtm please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1736 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVucHSjtzBnkLDsaTQQ9vQCdbgDFUw1-ks5s29IjgaJpZM4QfnAA>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, geeknoid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
What this PR does / why we need it:
NOTE: The changes in this PR were already approved by @douglas-reid @geeknoid. Old PR contained 12 files (#1617) but was reverted because of missing 2 generated pb.go file. I have added the missing 2 generated file in this PR (this PR therefore contains 14 files).
Note this is part 1 of sub message support. It is based on the proposal https://docs.google.com/document/d/1GL_EOitfBJDfgbQJOSROceK5RdqNPuiggeAebaNqyf8/edit#
This PR contains the code generation for the go Instances and the augmented proto messages (Type and InstanceParam)
Part 2 (following PR) will contain the bootstraping code generation (code that runs at run-time, inside Mixer framework and instantiates these sub-message artifacts generated in this PR).
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: