Skip to content

Port forward manager service and enable istio manager env var#155

Merged
kyessenov merged 6 commits intoistio:masterfrom
liamawhite:master
Apr 25, 2017
Merged

Port forward manager service and enable istio manager env var#155
kyessenov merged 6 commits intoistio:masterfrom
liamawhite:master

Conversation

@liamawhite
Copy link
Copy Markdown
Member

Signed-off-by: LIAM White liamwhite@uk.ibm.com

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

1 similar comment
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>
@kyessenov
Copy link
Copy Markdown
Contributor

I think we need to stick another container to istio-manager than runs the config server. We split it from from the discovery service.

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>
@ayj
Copy link
Copy Markdown
Contributor

ayj commented Apr 25, 2017

We had discussed colocating mixer and manager API server in its own logical deployment, i.e. istio-configserver. Not sure if that is still the plan though.

@liamawhite
Copy link
Copy Markdown
Member Author

Yeah, just realised currently we don't actually deploy the apiserver... So that won't help.

@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

LIAM White added 2 commits April 25, 2017 19:39
Signed-off-by: LIAM White <liamwhite@uk.ibm.com>
Signed-off-by: LIAM White <liamwhite@uk.ibm.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@kyessenov kyessenov merged commit ebec4ad into istio:master Apr 25, 2017
rshriram pushed a commit that referenced this pull request Oct 30, 2017
Port forward manager service and enable istio manager env var

Former-commit-id: ebec4ad
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
Port forward manager service and enable istio manager env var

Former-commit-id: ebec4ad
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Use reallink to read the localtime path
Temporarily turn off timezone to determine if it is necessary
Output the binaries /work/out/bin

This last solution^H^H^^Hack is a little problematic.  We need
to determine a cononical place to put our binaries in the event
a toolchain is not present, or output them in $(GOPATH)/bin if
the toolchain is present or configured.

This last point needs some thought.

This PR should be merged as is to unblock Mac developers.
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
…ter-merge_upstream_istio_master-6253864e

Automator: merge upstream changes to openshift-service-mesh/istio@master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants