Skip to content

add liveness probe for citadel.#13547

Closed
morvencao wants to merge 1 commit intoistio:masterfrom
morvencao:br_add_probe_for_citadel
Closed

add liveness probe for citadel.#13547
morvencao wants to merge 1 commit intoistio:masterfrom
morvencao:br_add_probe_for_citadel

Conversation

@morvencao
Copy link
Copy Markdown
Member

@morvencao morvencao commented Apr 23, 2019

merge #12734 to master.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao morvencao mentioned this pull request Apr 23, 2019
Merged
@morvencao morvencao removed the request for review from gyliu513 April 23, 2019 12:30
@stale
Copy link
Copy Markdown

stale bot commented May 7, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label May 7, 2019
@stuart-warren
Copy link
Copy Markdown
Contributor

stuart-warren commented May 7, 2019

still need this thanks

@stale stale bot removed the stale label May 7, 2019
@morvencao
Copy link
Copy Markdown
Member Author

morvencao commented May 7, 2019

@stuart-mclaren Have merged into new installer: istio/installer#81
Will check if we need to merge this.

@morvencao
Copy link
Copy Markdown
Member Author

morvencao commented May 13, 2019

Close this as we have this in master.

@morvencao morvencao closed this May 13, 2019
@morvencao morvencao deleted the br_add_probe_for_citadel branch May 13, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linsun linsun Awaiting requested review from linsun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morvencao @istio-testing @stuart-warren @googlebot