This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Merged
Conversation
6dd34b5 to
a147dad
Compare
sdake
reviewed
Apr 29, 2019
| livenessProbe: | ||
| httpGet: | ||
| path: /version | ||
| port: {{ .Values.global.monitoringPort }} |
Member
There was a problem hiding this comment.
This is not in globals.yaml. I believe we decided to hardcode the monitoring port for 1.2.
Contributor
There was a problem hiding this comment.
Yes, some of the settings we never tested and likely don't support should be replaced by default values.
We support kustomize for cases user really needs a custom value.
sdake
reviewed
Apr 29, 2019
Member
sdake
left a comment
There was a problem hiding this comment.
I believe we decided to hardcode the monitoring port for 1.2.
Member
|
A grep of istio-installer shows 15014 port is hardcoded. |
Member
Author
|
@sdake Thanks, replace probe port with hard coded value. |
664b091 to
844d4a8
Compare
c2054b3 to
6f39c60
Compare
added 4 commits
May 3, 2019 09:44
Signed-off-by: llcao <llcao@cn.ibm.com>
2e433f0 to
812557b
Compare
linsun
approved these changes
May 7, 2019
Member
linsun
left a comment
There was a problem hiding this comment.
all comments resolved.
/lgtm
/approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.