Skip to content

Cherry-Pick to 1.0: update certificates in tests with expiration time 100 years (#13233)#13456

Merged
duderino merged 1 commit intoistio:release-1.0from
howardjohn:1.0-tls-certs
Jun 5, 2019
Merged

Cherry-Pick to 1.0: update certificates in tests with expiration time 100 years (#13233)#13456
duderino merged 1 commit intoistio:release-1.0from
howardjohn:1.0-tls-certs

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Apr 19, 2019

This is causing failures of the release tests https://testgrid.k8s.io/istio-release#unit-tests&width=20

@hzxuzhonghu @howardjohn
update certificates with expiration time 100 years (istio#13233)
e772302 
* update certificates with expiration time 100 years

* update testdata/local/etc/certs
@howardjohn howardjohn requested a review from hzxuzhonghu April 19, 2019 14:50
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 19, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Apr 19, 2019
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Apr 19, 2019

Lint is not something we can easily fix, its related to not pinning the linter version. Not worth the effort to fix for 1.0

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Apr 20, 2019

Agreed
/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 20, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn, hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn howardjohn added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Apr 22, 2019
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 22, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Apr 22, 2019

/assign @costinm
I think you are the only owner active

@stale
Copy link
Copy Markdown

stale bot commented May 6, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label May 6, 2019
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented May 6, 2019

Not stale

@stale stale bot removed the stale label May 6, 2019
@stale
Copy link
Copy Markdown

stale bot commented May 20, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label May 20, 2019
@howardjohn howardjohn closed this May 21, 2019
@howardjohn howardjohn deleted the 1.0-tls-certs branch May 21, 2019 16:58
@howardjohn howardjohn restored the 1.0-tls-certs branch June 5, 2019 16:43
@howardjohn howardjohn reopened this Jun 5, 2019
@stale stale bot removed the stale label Jun 5, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2019

Codecov Report

Merging #13456 into release-1.0 will increase coverage by 1%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.0   #13456   +/-   ##
============================================
+ Coverage           72%      72%   +1%     
============================================
  Files              366      366           
  Lines            32365    32408   +43     
============================================
+ Hits             23213    23264   +51     
+ Misses            8165     8160    -5     
+ Partials           987      984    -3
Impacted Files Coverage Δ
pilot/pkg/model/jwks_resolver.go 63% <0%> (-4%) ⬇️
mixer/pkg/config/store/fsstore.go 94% <0%> (-2%) ⬇️
mixer/adapter/signalfx/signalfx.go 82% <0%> (-2%) ⬇️
mixer/adapter/fluentd/fluentd.go 87% <0%> (-1%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 84% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/cache.go 94% <0%> (-1%) ⬇️
mixer/adapter/rbac/rbac.go 11% <0%> (ø) ⬇️
mixer/adapter/memquota/memquota.go 100% <0%> (ø) ⬆️
... and 9 more

@wattli wattli changed the title Cherry-Pick to 1.0: update certificates with expiration time 100 years (#13233) Cherry-Pick to 1.0: update certificates in tests with expiration time 100 years (#13233) Jun 5, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 5, 2019

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-mixer-no_auth.sh e772302 link /test e2e-mixer-no_auth
prow/e2e-dashboard.sh e772302 link /test e2e-dashboard
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duderino duderino merged commit f31a5a1 into istio:release-1.0 Jun 5, 2019
@duderino duderino mentioned this pull request Jun 5, 2019
Merged
icygalz pushed a commit to icygalz/istio that referenced this pull request Jun 18, 2019
@howardjohn @icygalz
update certificates with expiration time 100 years (istio#13233) (ist…
e8bb483 
…io#13456)

* update certificates with expiration time 100 years

* update testdata/local/etc/certs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@baodongli baodongli Awaiting requested review from baodongli

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

Assignees

@costinm costinm

@hzxuzhonghu hzxuzhonghu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@howardjohn @googlebot @hzxuzhonghu @istio-testing @costinm @duderino