Skip to content

clarify istioctl developer instructions#125

Merged
rshriram merged 2 commits intomasterfrom
istio_fixes
Apr 10, 2017
Merged

clarify istioctl developer instructions#125
rshriram merged 2 commits intomasterfrom
istio_fixes

Conversation

@frankbu
Copy link
Copy Markdown
Contributor

@frankbu frankbu commented Apr 10, 2017

No description provided.

@frankbu frankbu requested a review from esnible April 10, 2017 18:55
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

1 similar comment
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Apr 10, 2017
@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@rshriram rshriram merged commit cd8c59a into master Apr 10, 2017
@frankbu frankbu deleted the istio_fixes branch April 10, 2017 21:53
zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
* add lower level configuring mixer document in tasks

* review comments

* review comments, and variables

* move to concepts, and links

* format bash and output per style guide
rshriram pushed a commit that referenced this pull request Oct 30, 2017
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Feb 12, 2021
This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.
luksa pushed a commit to luksa/istio that referenced this pull request Jun 30, 2021
This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.
luksa pushed a commit to luksa/istio that referenced this pull request Feb 22, 2022
…ss (istio#255)

This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.
luksa pushed a commit to luksa/istio that referenced this pull request Apr 29, 2022
…ss (istio#255)

This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.
luksa pushed a commit to luksa/istio that referenced this pull request Sep 15, 2022
…ss (istio#255) (istio#545)

This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.

Co-authored-by: Brad Ison <brad.ison@redhat.com>
luksa pushed a commit to luksa/istio that referenced this pull request Aug 16, 2023
…ss (istio#255) (istio#545)

This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.

Co-authored-by: Brad Ison <brad.ison@redhat.com>
dgn pushed a commit to dgn/istio that referenced this pull request Jun 13, 2024
…ss (istio#255) (istio#545)

This is a reimplementation of the following for the Maistra 2.1 /
Istio 1.8 rebase:

 - MAISTRA-1723: Allow disabling NodePort gateway support (istio#180)
 - Ensure Pilot can run without privileges for reading nodes (istio#125)

A new istiod flag is added, `disableNodeAccess`, that will disable any
feature relying on access to Node objects.

--------

Co-authored-by: Brad Ison <brad.ison@redhat.com>
Co-authored-by: Jacek Ewertowski <jewertow@redhat.com>
Signed-off-by: Yann Liu <yannliu@redhat.com>
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
…ter-merge_upstream_istio_master-6253864e

Automator: merge upstream changes to openshift-service-mesh/istio@master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants