Skip to content

Update vendored istio.io/api dependency#12160

Closed
drichelson wants to merge 1 commit intoistio:release-1.1from
drichelson:updateApiDep
Closed

Update vendored istio.io/api dependency#12160
drichelson wants to merge 1 commit intoistio:release-1.1from
drichelson:updateApiDep

Conversation

@drichelson
Copy link
Copy Markdown
Contributor

@drichelson drichelson commented Feb 28, 2019 •
edited
Loading

This PR only contains changes from running dep ensure -update istio.io/api
Related to #12160 and #11984

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drichelson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

Hi @drichelson. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@drichelson drichelson mentioned this pull request Feb 28, 2019
Closed
@drichelson
Copy link
Copy Markdown
Contributor Author

drichelson commented Feb 28, 2019

Closing since we are changing the target from release-1.1 to master for the original issue.

@drichelson drichelson closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geeknoid geeknoid Awaiting requested review from geeknoid

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drichelson @istio-testing @googlebot