Merged
Conversation
ijsnellf
approved these changes
Oct 23, 2017
| services: | ||
| details-v1-init: | ||
| image: istio/proxy_init:0.2.9 | ||
| image: gcr.io/istio-testing/proxy_init:e3f2b2252f76ba579e658764735cd0de10597557 |
Contributor
There was a problem hiding this comment.
is this meant to be a sha?
Member
|
/lgtm |
Member
Author
|
/lgtm |
Collaborator
|
@rshriram: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GregHanson, ijsnellf, rshriram The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Contributor
|
Will this task still work? |
Member
Author
|
yep |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
…ific go files. (istio#1202) Automatic merge from submit-queue Add dir check on the bazel_to_go script when symlinking template spec… …ific go files. **Release note**: ```release-note release-note-none ``` Former-commit-id: ab92820478997e5b27459ad94e368567252582f5
rshriram
added a commit
that referenced
this pull request
Oct 30, 2017
Automatic merge from submit-queue. Remove stale istio-egress **What this PR does / why we need it**: We no longer use istio-egress. It is not documented either. Has been superseded by egress rules. Also fixed updateVersion.sh to update sidecar version in bookinfo.sidecar.yaml files in Consul/Eureka. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` Former-commit-id: d2dca76
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
…ific go files. (#1202) Automatic merge from submit-queue Add dir check on the bazel_to_go script when symlinking template spec… …ific go files. **Release note**: ```release-note release-note-none ``` Former-commit-id: 2495e45e8c5b2c7c70277bea4ce5d5c8b0ef1ab1
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
Automatic merge from submit-queue. Remove stale istio-egress **What this PR does / why we need it**: We no longer use istio-egress. It is not documented either. Has been superseded by egress rules. Also fixed updateVersion.sh to update sidecar version in bookinfo.sidecar.yaml files in Consul/Eureka. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` Former-commit-id: d2dca76
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* DebugMode for kube-inject Fixes issue 1029 ```release-note Use istioctl kube-inject —debug=false to get production proxy image Default is true, which gives image you can sudo apt-get as needed ``` * Code review comment * More review comments * Make linter happy... Machine 1 Humans 0
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue. Remove stale istio-egress **What this PR does / why we need it**: We no longer use istio-egress. It is not documented either. Has been superseded by egress rules. Also fixed updateVersion.sh to update sidecar version in bookinfo.sidecar.yaml files in Consul/Eureka. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` Former-commit-id: d2dca76
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
* Fix env vars in Makefile * run tsan in circle ci
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We no longer use istio-egress. It is not documented either. Has been superseded by egress rules.
Also fixed updateVersion.sh to update sidecar version in bookinfo.sidecar.yaml files in Consul/Eureka.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: