Skip to content

Attempt #3 at fixing a bad link in a comment.#10532

Merged
geeknoid merged 1 commit intoistio:release-1.1from
geeknoid:release-1.1
Dec 19, 2018
Merged

Attempt #3 at fixing a bad link in a comment.#10532
geeknoid merged 1 commit intoistio:release-1.1from
geeknoid:release-1.1

Conversation

@geeknoid
Copy link
Copy Markdown
Contributor

Three times is the charm!

Three times is the charm!
Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun
Copy link
Copy Markdown
Member

linsun commented Dec 18, 2018

/test istio-pilot-e2e-envoyv2-v1alpha3

@istio-testing
Copy link
Copy Markdown
Collaborator

@geeknoid: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests.sh 3b928dc link /test e2e-simpleTests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid geeknoid merged commit c4e5ebf into istio:release-1.1 Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants