Update mixer configs to support access logs#101
Closed
ZackButcher wants to merge 0 commit intoistio:masterfrom
Closed
Update mixer configs to support access logs#101ZackButcher wants to merge 0 commit intoistio:masterfrom
ZackButcher wants to merge 0 commit intoistio:masterfrom
Conversation
Collaborator
|
Jenkins job istio/presubmit passed |
4 similar comments
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
frankbu
approved these changes
Apr 5, 2017
Contributor
frankbu
left a comment
There was a problem hiding this comment.
Looks good. Bookinfo demo working again with this change.
Merged
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
Former-commit-id: 0c28203abaa4fae171058d0f2c6ceb36762bcebb
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
Former-commit-id: 1b5ffae676e58e9daa83c05f5f39e6a037010dd2
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
…ager (#101) * Update gitignore * Adds qualification for auth * Fixed typo
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
…ager (#101) * Update gitignore * Adds qualification for auth * Fixed typo
rajusharma
pushed a commit
to rajusharma/istio
that referenced
this pull request
Jul 2, 2019
* More kustomization for demo and easy install * More progress in demo installer * Add kustomization bases * Remove citadel from template * Fix the generated files, had a TAG set * Fix hub * Update crd install * More fiddling with kustomize
vikaschoudhary16
pushed a commit
to vikaschoudhary16/istio
that referenced
this pull request
Oct 11, 2019
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
Signed-off-by: Jason Clark <jason.clark@ibm.com>
shonecyx
pushed a commit
to shonecyx/istio
that referenced
this pull request
Dec 24, 2021
* Protego cert integration (istio#56) * Move microvault to 9080 to avoid conflict (istio#64) * Add chart variable for mounting optional Secrets When protego is enabled, hedwig mutationwebhook will report error if optional Secret doesn't exist, so current template doesn't mount them at all. For primary-remote multi-cluster setup, primary istiod needs both protego and CA certs, this change adds additional variables to mount it. * sidecar microvault need writable /tmp Co-authored-by: Tong, Jonathan(jotong) <jotong@ebay.com>
myidpt
pushed a commit
that referenced
this pull request
Jun 9, 2022
lei-tang
pushed a commit
to lei-tang/istio
that referenced
this pull request
Jun 10, 2022
istio-testing
pushed a commit
that referenced
this pull request
Jun 10, 2022
antonioberben
pushed a commit
to antonioberben/istio
that referenced
this pull request
Jan 29, 2024
fix: add missing newline when setting custom storage environment variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't care about access logs in the demos/kube install then we can just delete this PR - the updated config is strictly optional in that it wasn't being set/used previously.
This can't be submitted before istio/old_mixer_repo#500.
This change is