Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
@jplevyak Could you please take a look? This is minimal change to make ticker work for wasm module. |
jplevyak
approved these changes
Apr 9, 2019
Author
|
@jplevyak Could you help me merge this or grant me write access to this repo? Thanks! |
rlenglet
pushed a commit
that referenced
this pull request
Aug 13, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
brian-avery
added a commit
that referenced
this pull request
Sep 29, 2020
* Patch 1 * Patch 3 * Patch 4 * Remove manual * Add fix from 1.6
istio-testing
pushed a commit
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes several changes to make timer work for wasm module:
tick_function pointer, seems to be usefulness.