[release-1.4] Fix create initial metadata #185
Closed
bianpengyuan wants to merge 2 commits intoistio:release-1.4from
Closed
[release-1.4] Fix create initial metadata #185bianpengyuan wants to merge 2 commits intoistio:release-1.4from
bianpengyuan wants to merge 2 commits intoistio:release-1.4from
Conversation
Author
|
@istio/release-managers-1-4 ptal, thanks. |
Member
|
Is this a backport? |
Author
|
Yes 1.5 pr: #158. master pr is blocked since it will need some clean up in ABI which is different from this fix: envoyproxy/envoy-wasm#417 |
|
@bianpengyuan do we need to fix this in oss? |
Author
|
@mandarjog You mean whether we need to fix it in 1.4? I think for sure we need to fix it in oss. this is a bug, Create Initial Metadata callback never really works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
ref: envoyproxy/envoy-wasm#414
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]