This repository was archived by the owner on Dec 16, 2020. It is now read-only.
Fix Wasm gRPC initial metadata callback#417
Closed
bianpengyuan wants to merge 5 commits intoenvoyproxy:masterfrom
Closed
Fix Wasm gRPC initial metadata callback#417bianpengyuan wants to merge 5 commits intoenvoyproxy:masterfrom
bianpengyuan wants to merge 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
fdbabfa to
1fed5c4
Compare
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Contributor
|
The test failures are real, you need to update API, regenerate SDK and/or update test files. Also, could you please add a test exercising gRPC callout (I thought we had one, so I'm not sure why it didn't catch this issue?), to make sure that the fix works? |
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
Contributor
Author
|
Yeah, wasm gen make file misses root_id.wasm. Seems like gRPC test does not exercise initial metadata code path. Will add a case for it. |
PiotrSikora
suggested changes
Feb 23, 2020
Contributor
PiotrSikora
left a comment
There was a problem hiding this comment.
Marking as blocked, pending changes discussed in #414.
Contributor
Author
|
Supersede by #461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#414
This change adds two member variables to gRPC handler, so that onCreateInitialMetadata could be triggered even the call token is not ready in the module.
cc @PiotrSikora
Signed-off-by: Pengyuan Bian bianpengyuan@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]