Conversation
howardjohn
left a comment
There was a problem hiding this comment.
is this in addition to normal gitignore?
Yes, this it is additive. xref: https://git-scm.com/docs/gitignore#_configuration |
| fi | ||
|
|
||
| # Setup common .gitignore | ||
| git config --local core.excludesfile ./common/config/.gitignore_common |
There was a problem hiding this comment.
The concern I see with this is it will modify the local environment when run outside of the container. I personally already have this setting set, so this would be mangling my setup.
Additionally, I suspect most people are using git outside of the container (direct git commands), so this won't apply there and they may get weird.
If we have common/.gitignore does it only apply to files inside of common/, or could we hack that to have 2 "real" gitignores?
There was a problem hiding this comment.
The concern I see with this is it will modify the local environment when run outside of the container. I personally already have this setting set, so this would be mangling my setup.
Yes, the fact that only one file can exist for core.excludesfile at each level would indeed be mangling the setup if the user already has it set.
If we have common/.gitignore does it only apply to files inside of common/, or could we hack that to have 2 "real" gitignores?
One option is to merge (i.e append) the common/.gitignore to the local .gitignore on make update-common. Alternatively, we could alias git to git -c ./common/.gitignore but it would only be scoped to Makefile rules. Otherwise, I am open to suggestions.
|
I like the idea, but the execution is flawed. I will reopen once I have a more robust solution. |
Support ignoring specific files/dirs when using
make(e.g.make check-clean-repo):