Skip to content

Revert "Add docker run script"#204

Merged
istio-testing merged 1 commit intomasterfrom
revert-172-run-script
Mar 7, 2020
Merged

Revert "Add docker run script"#204
istio-testing merged 1 commit intomasterfrom
revert-172-run-script

Conversation

@clarketm
Copy link
Copy Markdown
Member

@clarketm clarketm commented Mar 7, 2020

Reverts #172

Did the API change? Or there is probably an assumption that this is to run on Linux host? but FWIW make commands no longer work for me locally on MacOS after this merged (even when running in container).

$ BUILD_WITH_CONTAINER=1 make lint

/bin/sh: 1: set: Illegal option -o pipefail
common/Makefile.common.mk:33: recipe for target 'lint-yaml' failed
make[1]: *** [lint-yaml] Error 2
make: *** [Makefile:44: lint] Error 2
$ BUILD_WITH_CONTAINER=1 make update-common

mkdir: cannot create directory '/var/folders': Permission denied
common/Makefile.common.mk:98: recipe for target 'update-common' failed
make[1]: *** [update-common] Error 1
make: *** [Makefile:44: update-common] Error 2
$ BUILD_WITH_CONTAINER=1 make test

go: creating work dir: stat /var/folders/9j/nh3fxdf153v11vsjwtd1lf_800n1b6/T/: no such file or directory
Makefile.core.mk:23: recipe for target 'test' failed
make[1]: *** [test] Error 1
make: *** [Makefile:44: test] Error 2

@clarketm clarketm requested a review from a team as a code owner March 7, 2020 02:16
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Mar 7, 2020

😊 Welcome @clarketm! This is either your first contribution to the Istio common-files repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 7, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2020
@istio-testing istio-testing merged commit 9827381 into master Mar 7, 2020
@istio-testing istio-testing deleted the revert-172-run-script branch March 7, 2020 02:23
@clarketm clarketm mentioned this pull request Mar 7, 2020
Merged
fjglira pushed a commit to fjglira/istio-common-files that referenced this pull request Oct 22, 2025
@istio-testing
Automator: update common-files@master in istio/release-builder@master (…
fe0ea66 
…istio#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

@howardjohn howardjohn

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clarketm @istio-policy-bot @howardjohn @googlebot @istio-testing