Skip to content

Add idle_timeout field to DestinationRule#896

Merged
linsun merged 1 commit intoistio:release-1.1from
arianmotamedi:release-1.1
Apr 8, 2019
Merged

Add idle_timeout field to DestinationRule#896
linsun merged 1 commit intoistio:release-1.1from
arianmotamedi:release-1.1

Conversation

@arianmotamedi
Copy link
Copy Markdown
Contributor

@arianmotamedi arianmotamedi commented Apr 8, 2019

This is cherry-picked from #891.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 8, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 8, 2019

Hi @arianmotamedi. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arianmotamedi arianmotamedi mentioned this pull request Apr 8, 2019
Merged
@GregHanson
Copy link
Copy Markdown
Member

GregHanson commented Apr 8, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 8, 2019
@GregHanson
Copy link
Copy Markdown
Member

GregHanson commented Apr 8, 2019

/approve
/lgtm

linsun
linsun approved these changes Apr 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 8, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arianmotamedi, GregHanson, linsun
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren

If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun merged commit e9ab8d6 into istio:release-1.1 Apr 8, 2019
@arianmotamedi arianmotamedi mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linsun linsun linsun approved these changes

@diemtvu diemtvu Awaiting requested review from diemtvu

@kyessenov kyessenov Awaiting requested review from kyessenov

+1 more reviewer

@GregHanson GregHanson GregHanson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GregHanson GregHanson

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arianmotamedi @istio-testing @GregHanson @linsun @googlebot