Add idle_timeout field to DestinationRule#891
Add idle_timeout field to DestinationRule#891rshriram merged 3 commits intoistio:masterfrom arianmotamedi:upstream_idle_time
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arianmotamedi If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @arianmotamedi. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
/ok-to-test |
|
DR seems the right place for this. Any objection @frankbu @rshriram and others? Also, can we get this in release-1.1 since multiple users have reported this and it is preventing them from using istio in prod: istio/istio#9113 |
Per istio/istio#9113, updating DestinationRule to support an idle_timeout value for upstream http connections. This corresponds to Envoy's HttpProtocolOptions in the cluster definition: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-httpprotocoloptions. Pilot's implementation is done in istio/istio#13066.