Skip to content

Add idle_timeout field to DestinationRule#891

Merged
rshriram merged 3 commits intoistio:masterfrom
arianmotamedi:upstream_idle_time
Apr 5, 2019
Merged

Add idle_timeout field to DestinationRule#891
rshriram merged 3 commits intoistio:masterfrom
arianmotamedi:upstream_idle_time

Conversation

@arianmotamedi
Copy link
Copy Markdown
Contributor

@arianmotamedi arianmotamedi commented Apr 4, 2019

Per istio/istio#9113, updating DestinationRule to support an idle_timeout value for upstream http connections. This corresponds to Envoy's HttpProtocolOptions in the cluster definition: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-httpprotocoloptions. Pilot's implementation is done in istio/istio#13066.

@googlebot
Copy link
Copy Markdown
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arianmotamedi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog

If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Apr 4, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @arianmotamedi. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Apr 4, 2019
@linsun
Copy link
Copy Markdown
Member

linsun commented Apr 5, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 5, 2019
@linsun
Copy link
Copy Markdown
Member

linsun commented Apr 5, 2019

DR seems the right place for this.

Any objection @frankbu @rshriram and others?

Also, can we get this in release-1.1 since multiple users have reported this and it is preventing them from using istio in prod: istio/istio#9113

@rshriram rshriram merged commit 6b8d184 into istio:master Apr 5, 2019
@arianmotamedi arianmotamedi changed the title Adding idle_timeout field to DestinationRule Add idle_timeout field to DestinationRule Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants